jdaugherty commented on code in PR #15974:
URL: https://github.com/apache/grails-core/pull/15974#discussion_r3565464526
##########
grails-forge/grails-forge-core/src/main/resources/gsp/index.gsp:
##########
@@ -13,32 +14,38 @@
<!doctype html>
<html>
<head>
- <title>Welcome to Grails</title>
+ <title><g:message code="welcome.title"/></title>
<meta name="layout" content="main"/>
<asset:stylesheet src="welcome.css"/>
</head>
<body>
<main id="content" role="main" class="pb-4 pb-md-5">
<div class="container-lg py-2 py-md-3">
- <div class="row align-items-top g-4">
- <%-- WELCOME MESSAGE --%>
- <div class="col-12 col-md-7">
- <h1 class="display-6 fw-semibold mb-2">Welcome to Grails</h1>
- <p class="lead text-body-secondary">
- Congratulations, you have successfully started a Grails
application.
+ <%-- WELCOME HERO --%>
+ <section class="welcome-hero position-relative overflow-hidden
rounded-3 p-4 p-md-5 mb-4">
Review Comment:
On the design front, we'll probably want more feedback. For now, since we
need this to get the 8.0.0-M3 out, I'm ok merging. We will probably have to
readdress if anyone disagrees.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
