jamesfredley commented on PR #15965: URL: https://github.com/apache/grails-core/pull/15965#issuecomment-4997825734
Fair point on the brittleness. Worth separating the goal from the assertion style: The primary objective (pre-release review, Codebase 3 / hygiene quick-win) is to **remove the `jodd-wot` dependency** - `jodd-wot 3.3.8` dates to 2012 and is effectively unmaintained, and it's a single `testImplementation` usage in `grails-fields/build.gradle`. Getting it off the dependency list is the win. On *how* to replace the assertion, the review lists two options: "modern assertions" **or** "Jsoup or equivalent". The trade-off: - **String assertions** (current PR): removes `jodd-wot` with **zero new dependencies**, but is more brittle as you note. - **Jsoup**: robust HTML parsing, but re-adds a test dependency to replace the one we're removing. I'm happy to switch these to Jsoup (`org.jsoup:jsoup`, `testImplementation`) if you'd rather have a real parser and consider the added test dep acceptable - that still achieves the `jodd-wot` removal, just trading one modern dep for one archived one. Which would you prefer: keep it dependency-free with tightened assertions, or move to Jsoup? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
