borinquenkid commented on PR #15972:
URL: https://github.com/apache/grails-core/pull/15972#issuecomment-5017824072
@jdaugherty CI is unblocked now — the build-breaking failure was a
dependency conflict in `:grails-data-neo4j-docs:groovydoc`
(`grails-data-neo4j/docs/build.gradle` was still consuming the default
`grails-bom` instead of `grails-neo4j-bom`, so it pulled both the strict
`4.4.13` driver constraint transitively via `grails-data-neo4j-core` *and*
Spring Boot's `6.1.0` at the same time). Fixed in `f861bbe4fb` by switching
that one line to `platform(project(':grails-neo4j-bom'))`, matching every other
Neo4j subproject. All "Build Grails-Core" jobs are green again.
I went back through all 11 of your review threads and verified each one
against the current head (not just the reply text — actually checked the file
contents / re-ran the relevant Gradle tasks):
1. **`neo4j-driver` version must be BOM-managed** — ✅ confirmed. `strictly
4.4.13` lives in `dependencies.gradle`'s `customBomVersions`, consumed by
`grails-neo4j-bom`.
2. **Coordinate rename mappings / `gorm-neo4j-spring-boot` rename** — ✅
confirmed. `RENAME.md`, `rename_gradle_artifacts.sh`, and `settings.gradle` all
show `grails-data-neo4j-spring-boot`.
3. **`ignoreFailures=true` masking 270 CodeNarc violations** — ✅ confirmed.
Flag is gone from all three modules; I re-ran `codenarcMain`/`checkstyleMain`
on `grails-data-neo4j-core`, `grails-data-neo4j`, and
`grails-data-neo4j-spring-boot` from a clean state (`--rerun-tasks`) — all pass
with 0 violations.
4. **Missing `onlyNeo4jTests`/`skipNeo4jTests` + CI job + publish gating** —
✅ confirmed. Present in `test-config.gradle`, `functional-test-config.gradle`,
and `.github/workflows/gradle.yml` (`neo4jFunctional` is in `publish`'s `needs`
list and gates its `if:`).
5. **Stray `GORM_REGISTRY_MIGRATION.md` planning doc** — ✅ confirmed removed.
6. **`test-data-service`/`neo4j-standalone` example apps dropped** — ✅
confirmed. All 5 apps present under `grails-test-examples/neo4j/`.
7. **Forge integration + module naming convention** — ✅ confirmed.
`Neo4jGorm.java`/`Neo4JGormSpec.groovy` present in `grails-forge-core`; module
renamed to `grails-data-neo4j-core`.
8. **Stale renamed-module comments in `grails-data-tck-config.gradle`** — ✅
confirmed gone.
9. **Duplicated test/Jetty-force block across 3 modules** — ✅ confirmed
extracted to `grails-data-neo4j/gradle/neo4j-harness-test-config.gradle`,
applied via `apply from:` in all three.
10. **Driver-version override risking other Spring Boot apps — needs its own
BOM** — ✅ confirmed. `grails-neo4j-bom` exists as its own module; this is also
exactly what today's CI fix completed — the `docs` submodule was the one
remaining consumer that hadn't been switched over.
11. **Ad-hoc `resolutionStrategy.force` for the driver** — ✅ confirmed
removed from all three modules; no local force blocks remain.
One process note: all 11 threads still show as unresolved in the GitHub UI,
including the two where I'd already written "marking this resolved" in the
comment text — that text never actually triggered the "Resolve conversation"
button. I'll go click resolve on the ones above now that they're re-verified,
so they're not sitting open for you to re-check by hand.
Remaining CI failures on this run are both confirmed pre-existing, not
regressions from this migration:
- `OptimisticLockingSpec > Test optimistic locking` — timing-sensitive
concurrent-update race (the TCK harness needs genuinely independent sessions to
observe a stale read); reproduced 0/3 times locally across multiple runs, fails
3/3 in CI's more contended environment. Predates this PR.
- Selenium `SessionNotCreatedException: Chrome instance exited` in the Neo4j
example app functional tests — same failure signature also hit
`grails-test-examples-spring-security-ldap-functional-test-app` on this same
run, so it's a repo-wide Selenium/ChromeDriver infra flake, not Neo4j-specific
(likely the same missing-`wait{}` root cause called out in #15792).
Should be ready for a fresh look whenever you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
