The GitHub Actions job "CI" on grails-intellij-plugin.git/main has succeeded.
Run started by GitHub user jdaugherty (triggered by jdaugherty).

Head commit for run:
25f4c7dfc419c7a7d6661b384fe30d57461c94ba / James Daugherty 
<[email protected]>
Restore JavaVersionMatcher's package, broken by the repackage

CI failed compiling libs/testFramework:

  JavaVersionRestriction.kt:22 Unresolved reference 'JavaVersionMatcher'

Fallout from the repackage. That commit had to rewrite package declarations 
from each
file's path, because for the two split packages a prefix rewrite could not tell 
the
owning project apart. Deriving the package from the path assumes package == 
directory,
which Kotlin does not require: JavaVersionMatcher.kt sits in tooling/ but 
declares
tooling.util, so it got "corrected" to tooling and the import in 
JavaVersionRestriction.kt
stopped resolving.

I saw this file in the fixer's output at the time and reverted the wrong one -- 
I matched
the reported package against `git ls-files .../tooling/util` and landed on
VersionMatcher.java, which had never been touched. Audited properly this time by
comparing every libs/testFramework package declaration against the commit 
before the
repackage: JavaVersionMatcher.kt is the only one that differs, and it is now 
byte-identical
to its pre-repackage state.

It stays where it is with its original package rather than moving into util/ to 
make
package match path: these are vendored copies of platform test-framework 
sources and
keeping them identical to upstream is what makes future re-syncs possible.

Local builds hid this because Kotlin's incremental cache still had the old 
output;
verified now by compiling from a pristine `git archive` checkout, and by running
testCodeCoverageReport, the task the coverage job runs.

Verified: 999 tests / 0 failures; rat clean.

Report URL: 
https://github.com/apache/grails-intellij-plugin/actions/runs/30221111473

With regards,
GitHub Actions via GitBox

Reply via email to