codeconsole commented on PR #15666: URL: https://github.com/apache/grails-core/pull/15666#issuecomment-5099529750
Thanks for the second pass. Both fair -- fixed in 4000654c8e: 1. **Silent wrong-type fallback**: confirmed, real bug. `resolveFiltererClass` now logs a warning when the value is neither `Class` nor `String` before falling back, plus a regression test with a List value. 2. **Test fidelity**: added a test that loads the Class-literal case through the real `GroovyConfigPropertySourceLoader` -> `ConfigSlurper` pipeline (temp `application.groovy` file) instead of a synthetic `MapPropertySource`. For what it's worth, I traced `NavigableMapPropertySource.getProperty` and confirmed it behaves identically to `MapPropertySource` for a raw `Class` value (no extra conversion), so the synthetic test wasn't masking a real behavioral gap -- but the new test is the more direct proof. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
