borinquenkid opened a new pull request, #16072:
URL: https://github.com/apache/grails-core/pull/16072
## Summary
- Follow-up to #16070 (merged). Copilot's review flagged that the second
test's `Thread.start { ... }.join(2000)` can return on timeout without the
background thread having actually finished, so the "same headroom rationale"
comment added in #16070 was inaccurate there.
- Captures the thread and asserts `!isAlive()` after the bounded
`join(5000)` so a slow runner fails loudly instead of silently racing the
assertions that follow, instead of swallowing a potential
`InterruptedException` and hoping for the best.
## Test plan
- [ ] CI run of `grails.gorm.tests.OptimisticLockingSpec` in
`grails-data-neo4j` (could not execute this module's tests locally — it's
pinned to `grails-gradle-plugins:6.1.2`, which 404s from `repo.grails.org` and
isn't in local caches, a pre-existing environment gap unrelated to this change)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
