The GitHub Actions job "CI" on grails-core.git/spike/grails-beans-dsl has 
succeeded.
Run started by GitHub user codeconsole (triggered by codeconsole).

Head commit for run:
9f18a77067b2c27ec7792362dc09032000666dd0 / Scott Murphy Heiberg 
<[email protected]>
Cover the relaxed-boolean path that motivated the cache fix

The spec exercised grails.cache.enabled=false, which never disagreed. The 
values that do -
yes, on and 1, which @ConditionalOnBooleanProperty reads as disabled and
config.getProperty(..., Boolean) as enabled - had no test, so the regression 
the fix was
written for was not covered.

Three unrolled cases assert the beans are absent and that 
doWithApplicationContext backs
off rather than throwing. Against the previous implementation all three fail 
with
NoSuchBeanDefinitionException, which is the production failure: the hook read 
the property
back, resolved it as true, and asked for a bean the condition had just declined 
to
register.

Wiring the plugin with a GrailsApplication carrying the same configuration is 
what makes
that real. Without it the old implementation failed these tests too, but on a
NullPointerException from an unset grailsApplication - an artefact of the 
harness rather
than the path being tested.

A fourth case runs the hook on the enabled context and asserts it creates the 
default
caches, so the back-off above cannot pass by being taken unconditionally.

Report URL: https://github.com/apache/grails-core/actions/runs/30609516398

With regards,
GitHub Actions via GitBox

Reply via email to