The GitHub Actions job "CI" on grails-core.git/spike/grails-beans-dsl has 
succeeded.
Run started by GitHub user codeconsole (triggered by codeconsole).

Head commit for run:
c3c9b4986dff7e9e756f5892ad4aec61cc7ebfaf / Scott Murphy Heiberg 
<[email protected]>
Address review: correct the Application beans docs and drop a redundant comment

The application lifecycle chapter said an Application class defines beans at
compile time "by annotating it with @GrailsBeans". It does not need the
annotation: the global transform compiles a DSL-shaped beans property on any
GrailsAutoConfiguration subclass, which is what Application extends, so beans
is a convention there exactly as doWithSpring is. The plugin and Spring
chapters already said so; this one contradicted them.

That path had no test. The three existing implicit-convention cases all use
*GrailsPlugin.groovy sources, which reach the transform through a different
branch and a different filename rule, so the Application branch was covered
nowhere. Add a case that compiles an Application from grails-app/init, where
a generated project puts it and where the transform's project-source check
actually admits it.

Also drop the comment above DomainClassGrailsPlugin's beans block. It
described the constructor of a class this PR deletes, which tells a future
reader nothing about the code in front of them.

Report URL: https://github.com/apache/grails-core/actions/runs/30830848386

With regards,
GitHub Actions via GitBox

Reply via email to