The GitHub Actions job "CI" on grails-core.git/fix/flaky-per-test-recording-spec has failed. Run started by GitHub user borinquenkid (triggered by borinquenkid).
Head commit for run: 08800e41145a919ec2c2cbe9b10d80b23a35b6f1 / Walter Duque de Estrada <[email protected]> Add unit coverage for WebDriverContainerHolder and ground the recording size floor in real measurements jdaugherty's review on PR #16031 flagged two gaps in the previous commit: WebDriverContainerHolder's stop()/restartVncRecordingContainer() changes had no test coverage of their own, and MIN_MEANINGFUL_RECORDING_BYTES was justified only by an unquantified "tens of KB" claim. - Add WebDriverContainerHolderSpec: unit-tests stop()'s try/finally state reset (both the happy path and when container.stop() throws), and restartVncRecordingContainer()'s guard clauses plus its swallow-and-log behavior when the current recording container fails to stop. All exercised via Mocks - no Docker required. - PerTestRecordingSpec: replace the vague size justification with numbers from two real local runs against the VNC recording container (75KB-855KB per genuine recording), and document why the byte-mismatch check is kept alongside the size floor rather than replaced by it - the two assertions guard against different failure modes (near-blank captures vs. two recordings accidentally being the same file). Co-Authored-By: Claude Sonnet 5 <[email protected]> Report URL: https://github.com/apache/grails-core/actions/runs/30682611426 With regards, GitHub Actions via GitBox
