matrei commented on code in PR #15947:
URL: https://github.com/apache/grails-core/pull/15947#discussion_r3629002904
##########
grails-controllers/src/main/groovy/grails/artefact/Controller.groovy:
##########
@@ -363,6 +363,11 @@ trait Controller implements ResponseRenderer,
ResponseRedirector, RequestForward
*/
@Generated
def initializeCommandObject(final Class type, final String
commandObjectParameterName) throws Exception {
+ initializeCommandObject(type, commandObjectParameterName, null)
+ }
+
+ @Generated
+ def initializeCommandObject(final Class type, final String
commandObjectParameterName, final List bindAllowedProperties) throws Exception {
Review Comment:
Consider not using `final` for method params and local variables?
I know this aligns with previous code but it is really bad for readability
for, in my opinion, almost always no gain. New or changed code should not use
`final`.
##########
grails-core/src/main/groovy/grails/config/Settings.groovy:
##########
@@ -392,6 +392,8 @@ interface Settings {
String DATE_LENIENT_PARSING = 'grails.databinding.dateParsingLenient'
+ String LEGACY_BINDABLE_DEFAULT = 'grails.databinding.legacyBindableDefault'
Review Comment:
`String DATABINDING_DENY_BY_DEFAULT = grails.databinding.denyByDefault`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
