The GitHub Actions job "CI" on grails-core.git/feat/enable-datamapping-rx has 
succeeded.
Run started by GitHub user borinquenkid (triggered by borinquenkid).

Head commit for run:
131b7694ad536788b28e888482d9fccdc23f8ea6 / Walter Duque de Estrada 
<[email protected]>
Re-enable grails-datamapping-rx module

The module was disabled in settings.gradle (and 
gradle/publish-root-config.gradle,
which independently gated GrailsPublishExtension registration) pending a port to
the current Grails release. This restores it to the active build:

- Fix RxSchedule.java: an @interface illegally declared a `default` annotation
  member with a method body instead of a constant default value, and referenced
  a removed GroovyTransformOrder constant (RX_SCHEDULE -> RX_SCHEDULER_ORDER).
- Fix grails.gorm.rx.DetachedCriteria.clone(): illegally narrowed visibility
  from the inherited public AbstractDetachedCriteria.clone().
- Fix RxEntity.groovy: missing `import rx.Observable`.
- Fix RxScheduleIOTransformation.groovy: same stale GroovyTransformOrder
  constant reference (RX_SCHEDULE_IO_ORDER -> RX_SCHEDULER_ORDER).
- Fix FindByFinder/FindAllByFinder (rx): both called a 3-arg buildQuery(...)
  overload that no longer exists after the finders' Groovy->Java conversion;
  inlined the query-building steps 
(applyAdditionalCriteria/applyDetachedCriteria/
  configureQueryWithArguments/getJunction) that the current 2-arg buildQuery
  performs internally, using the query the finder already creates via
  RxDatastoreClient instead of a Session.
- Bring the module's Checkstyle and CodeNarc compliance up to date with the
  rest of the codebase (it had never been checked while disabled).

Compiles, and its test suite passes (8/8).

Co-Authored-By: Claude Sonnet 5 <[email protected]>

Report URL: https://github.com/apache/grails-core/actions/runs/31511015471

With regards,
GitHub Actions via GitBox

Reply via email to