The GitHub Actions job "CI - Groovy Joint Validation Build" on 
grails-core.git/fix/aot-live-instance-beans-8.0.x has failed.
Run started by GitHub user codeconsole (triggered by codeconsole).

Head commit for run:
fb6518ead975a30780358db028c42263d5076416 / Scott Murphy Heiberg 
<[email protected]>
Check where a form page was answered from, as a path already is

Asking for a form page follows redirects, and where it landed went unchecked. A
page behind a login answers from the login form, and everything after that 
passes:
that page has a form, its fields are filled in, it posts, and it answers below 
400.
What was reported was the login form submitted a second time under the name of 
the
page that was wanted, while the binding it was listed for went unexercised. The
same happens with credentials that are rejected -- every protected form after 
them
falls back to the login page and is recorded as that.

The check ask() already makes, made here too, and failing rather than warning: a
path that redirects still traced a page, and an application is free to send one
page to another; a form that redirects traced a different form, and there is no
reading of that which is what was asked for. A status of 400 or worse asking for
the page fails here as well, rather than being left to look like a page with no
form on it.

The fixture grew a form only a signed-in visitor is shown, which is the shape 
that
made this pass: the page it lands on has a form of its own. Confirmed capable of
failing -- with the check disabled, the new spec sees POST /authenticate 
recorded
under the protected page's name.

Report URL: https://github.com/apache/grails-core/actions/runs/31625201231

With regards,
GitHub Actions via GitBox

Reply via email to