The GitHub Actions job "CI" on grails-core.git/chore/cleanup-AbstractCriteriaBuilder has succeeded. Run started by GitHub user borinquenkid (triggered by borinquenkid).
Head commit for run: 377a7f50ef183a9cc4772570ea2a665433067dd1 / Walter Duque de Estrada <[email protected]> Fix IntelliJ inspection warnings on AbstractCriteriaBuilder - Removed 2 truly-unused public constants (ORDER_DESCENDING/ORDER_ASCENDING) after confirming zero references anywhere in the repo; the class's own order(String, String) already used grails.gorm.CriteriaBuilder's identical constants instead. - Parameterized raw uses of Class, PersistentProperty, Association, Closure, QueryableCriteria, and DetachedCriteria. - Converted 3 instanceof-plus-cast blocks to Java pattern variables. - Replaced a redundant `associationQuery instanceof AssociationQuery` check with a null check, since Query.createQuery(String) is declared to return AssociationQuery directly, making the instanceof always true. - Replaced manual list.get(size()-1)/remove(size()-1) with getLast()/removeLast(). - Extracted the duplicated MetaMethod lookup-and-invoke block in invokeMethod into a private helper, using a NOT_FOUND sentinel to preserve the exact "found but returned null" vs "not found" distinction the original two copies each handled inline. - Left 2 items as accepted/suppressed rather than "fixed" incorrectly: in(String, Collection) and inList(String, Collection) keep a raw Collection parameter with @SuppressWarnings("rawtypes"), since Criteria's own declaration is raw and a parameterized override would not actually override it (name clash, not an override, due to erasure); addToCriteria keeps @SuppressWarnings("UnusedReturnValue") since most callers discard its return value by design, even though a few legitimately use it. - Also drops an unused Criteria import from grails.gorm.rx.CriteriaBuilder. AbstractCriteriaBuilder coverage held at 99.7% lines / 100% methods / 90% branches throughout; all changes verified semantic-preserving. Co-Authored-By: Claude Sonnet 5 <[email protected]> Report URL: https://github.com/apache/grails-core/actions/runs/31628574725 With regards, GitHub Actions via GitBox
