borinquenkid commented on PR #15993: URL: https://github.com/apache/grails-core/pull/15993#issuecomment-5458415887
@jdaugherty following up on the classloader-binding question from July — wanted to loop back with the CI story since it's been a source of confusion on this PR. **Status update:** I re-ran CI and Coverage against the current HEAD (`b8fd78d243`) via `workflow_dispatch`, and both came back fully green: - CI: https://github.com/apache/grails-core/actions/runs/33202800706 (46/46 jobs, all platforms/JDKs) - Coverage: https://github.com/apache/grails-core/actions/runs/33202803098 This matters because **no CI had actually run against the last two commits in three weeks** — the two `Merge branch '8.0.x'` commits (`9c1a834c15`, `b8fd78d243`) never triggered a workflow run, so the PR looked stale/red from the last real signal (commit `c75b73ec1e`, 2026-08-02, where all three `ProfilingGrailsPluginManagerSpec` tests failed on every OS/JDK). That failure was a test-fragility issue, not a code defect: the original spec asserted on captured `System.err` text, which is sensitive to which SLF4J provider gets resolved in a given environment. The merge from `8.0.x` pulled in the `LogCapture` test fixture and rewrote the spec to assert on actual Logback events instead — I confirmed locally that all three tests pass reliably with that fix. I also re-checked patch coverage against jacoco data for `ProfilingGrailsPluginManager.java` and `SpringApplicationRunner.java` (the two files Codecov flagged early on) — every line the diff touches is now covered; that earlier 13.9%-patch-coverage comment was against a since-superseded commit. Ran the full verification suite from the PR description locally as well (`grails-bootstrap`, `grails-core`, `grails-shell-cli`, `grails-data-hibernate5`, `grails-data-hibernate7`, `grails-forge-core`) — all green. Given CI is now actually green against HEAD and the open question from July has empirical evidence behind it, I'm approving. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
