sbglasius commented on code in PR #16281:
URL: https://github.com/apache/grails-core/pull/16281#discussion_r3898551933
##########
grails-web-common/src/main/groovy/grails/web/servlet/mvc/GrailsParameterMap.java:
##########
@@ -234,9 +236,19 @@ public String toQueryString() {
}
/**
- * @return The identifier in the request
+ * Returns the identifier in the request.
+ *
+ * <p>A request parameter literally named {@code identifier} takes
precedence, so that a form
+ * field of that name stays reachable through this accessor as well as
through
+ * {@code params['identifier']}. Otherwise the conventional {@code id}
parameter is returned,
+ * which is the long-standing behaviour of this method.
+ *
+ * @return the {@code identifier} parameter when one is present, otherwise
the {@code id} parameter
*/
public Object getIdentifier() {
Review Comment:
This is what triggered the error I discovered, that a test would not allow
me to do:
```
params.identifier = "123"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
