codeconsole commented on code in PR #16149: URL: https://github.com/apache/grails-core/pull/16149#discussion_r3916657927
########## grails-benchmarks/README.adoc: ########## Review Comment: Taken the second option in 93c8ffd - `grails-benchmarks` is now named in `testProjectsStartWith`. The two places that key off those prefixes are the BOM enumeration and the functional-test coordinate substitution, and neither has anything to take from it: the module deliberately omits the publish plugin, since its JMH dependency is Category X, so the BOM was already skipping it on the published-project check further down. Naming it says that on purpose instead of leaving it to that second check. Renaming it under `grails-test-examples` looked like the worse of the two: the directory is referenced from the JMH workflow, the comparison tooling and the README, and that tree is for applications exercising Grails as an application rather than for a build-time harness. Happy to move it instead if you would rather the convention hold without exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
