codeconsole commented on code in PR #16149: URL: https://github.com/apache/grails-core/pull/16149#discussion_r3916781293
########## grails-test-examples/benchmarks/README.adoc: ########## Review Comment: Correcting myself - I took the exclusion first and it was the wrong call. Moved instead, in 14ae491: `grails-test-examples-benchmarks`, under `grails-test-examples/benchmarks`, and the `testProjectsStartWith` entry reverted with it. You were right that it is a rogue module. It was declared in the framework `include(...)` block between `grails-bootstrap` and `grails-beans-dsl` while being unpublishable, so three separate mechanisms that read the prefix had to be told about it individually - and its own build file already listed four plugins it omits for the same reason. My exclusion would have made five. The prefix now carries the classification instead. Cost was five files: settings, root build, the workflow's task paths, the RAT exclusion for the golden report fixtures, and the module README. One thing to know: the workflow probes the base revision for the project directory before comparing against it, so a base from before this commit falls back to head-only mode, which it already handles and reports. `compileJmhJava`, the module's tests, `rat`, and the BOM check all pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
