Copilot commented on code in PR #16307:
URL: https://github.com/apache/grails-core/pull/16307#discussion_r3920116140
##########
grails-data-mongodb/bson/src/main/groovy/org/grails/datastore/bson/json/JsonScanner.java:
##########
@@ -361,6 +361,7 @@ private JsonToken scanNumber(final char firstChar) throws
IOException {
case JsonToken.CLOSE_BRACE:
case JsonToken.CLOSE_BRACKET:
case JsonToken.CLOSE_PARENS:
+ case -1:
state = JsonScanner.NumberState.DONE;
break;
Review Comment:
`SAW_EXPONENT_DIGITS` now treats end-of-input (`-1`) as a delimiter, but
`scanNumber` later unreads the delimiter. Unreading `-1` into a
`PushbackReader` pushes a 0xFFFF character, which can break subsequent
tokenization (e.g., the next `readBsonType()` expecting EOF). Treat EOF like
whitespace so the unread buffer stays valid.
This issue also appears on line 387 of the same file.
##########
.github/workflows/gradle.yml:
##########
@@ -1187,12 +1187,6 @@ jobs:
if: github.repository_owner == 'apache' && github.event_name == 'push'
needs: [ publish ]
runs-on: ubuntu-24.04
- # Documentation publishing targets a shared resource (the
apache/grails-website repo).
- # Share the static group used by the release documentation publish
(release.yml) so only
- # one documentation publish can run at a time across every branch; the
rest queue.
- concurrency:
- group: grails-docs-publish
- cancel-in-progress: false
steps:
Review Comment:
This docs publish job also deploys to the shared apache/grails-website repo,
but the job-level `concurrency` block was removed. Multiple pushes can now
publish concurrently, which can lead to git push conflicts or partial
overwrites of the generated docs folder.
##########
.github/workflows/release.yml:
##########
@@ -633,20 +633,14 @@ jobs:
run: |
echo "::group::Manual Grails Forge deployment"
echo "Deploy Forge via
https://github.com/apache/grails-core/actions/workflows/forge-deploy-aws.yml";
- echo "Use workflow from the maintenance branch. Choose slot latest,
snapshot, next, prev, or prev-snapshot."
+ echo "Use workflow from the maintenance branch. Choose slot latest,
snapshot, next, next-snapshot, prev, prev-snapshot, or older."
echo "Do not run this workflow from a historical git tag."
echo "::endgroup::"
docs:
environment: docs
name: "VOTE SUCCEEDED - Publish Documentation"
needs: [ publish, source, upload, release ]
runs-on: ubuntu-24.04
- # Documentation publishing targets a shared resource (the
apache/grails-website repo).
- # Use a static, branch-independent group so only one documentation publish
can run at a
- # time across every branch and across the snapshot publish in gradle.yml;
the rest queue.
- concurrency:
- group: grails-docs-publish
- cancel-in-progress: false
steps:
Review Comment:
The docs job publishes to the shared apache/grails-website repo, but the
job-level `concurrency` block was removed. Without a static concurrency group,
pushes/releases from different branches can publish docs simultaneously and
race on the same target branch/folder, causing failed pushes or inconsistent
site contents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
