sbglasius commented on code in PR #16296:
URL: https://github.com/apache/grails-core/pull/16296#discussion_r3922123399
##########
grails-converters/src/main/groovy/org/grails/web/converters/marshaller/json/GenericJavaBeanMarshaller.java:
##########
@@ -64,14 +66,17 @@ public void marshalObject(Object o, JSON json) throws
ConverterException {
if (Modifier.isStatic(readMethod.getModifiers())) continue;
if (readMethod.getAnnotation(PersistenceMethod.class) !=
null) continue;
if (readMethod.getAnnotation(ControllerMethod.class) !=
null) continue;
- Object value = readMethod.invoke(o, (Object[]) null);
+ Method invokableMethod =
ClassUtils.getInterfaceMethodIfPossible(readMethod, clazz);
Review Comment:
@jdaugherty I don't feel we reached an agreement on the weekly?
And with regards to a case, where access is widened, is that even a problem.
Every developer can do so them self, using the exact same techniques.
We could also easily go for the "not mutated" case.
IMO Grails does not have to become the framework where everything has to be
according to standards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
