The GitHub Actions job "Code Style" on grails-core.git/feat/beans-dsl-diagnostics-8.0.x has succeeded. Run started by GitHub user codeconsole (triggered by codeconsole).
Head commit for run: c4cadbba59e7fda9e56e74d76de72be3ffbadedf / Scott Murphy Heiberg <[email protected]> Stop asserting an ordering @ConditionalOnBean does not guarantee CI failed on the positive half of the conditionalOnBean test: the transport bean existed and the adapter still did not register. The test declared both in one beans block, so whether the condition matched depended on @Bean method order within a single class - it passed locally and failed on CI, where the build now compiles with invokedynamic off. That is the annotation working as documented, not a transform bug. @ConditionalOnBean matches only against bean definitions the context has already processed, which is exactly why Spring restricts it to auto-configurations. A bean naming another declared beside it is not a condition that reliably holds. The transport now comes from a separate @Configuration registered before the fixture, which is the one ordering the annotation does guarantee, so both halves are deterministic. The javadoc says so too - the qualifier had no note about it, and the caveat is the kind this DSL otherwise makes a point of naming. Also fixes the checkstyle ImportOrder violation that came in with group(...): GenericsType sorts before InnerClassNode. Report URL: https://github.com/apache/grails-core/actions/runs/34049434160 With regards, GitHub Actions via GitBox
