jdaugherty commented on code in PR #16386: URL: https://github.com/apache/grails-core/pull/16386#discussion_r4096247697
########## grails-doc/src/en/ref/Controllers/render.adoc: ########## @@ -109,5 +112,6 @@ Parameters: * `encoding` (optional) - The encoding of the response * `plugin` (optional) - The plugin to look for the template in * `status` (optional) - The HTTP status code to use -* `file` (optional) - The byte[], java.io.File, or inputStream you wish to send with the response -* `fileName` (optional) - For specifying an attachment file name while rendering a file. +* `file` (optional) - The byte[], java.io.File, or inputStream you wish to send with the response. File responses are rendered with `Content-Disposition: attachment` by default. +* `fileName` (optional) - For specifying an attachment file name while rendering a file. Unsafe characters in the filename are escaped before they are written to the header. +* `inline` (optional) - Set to `true` while rendering a file to omit the default attachment `Content-Disposition` header. Review Comment: The upgrade note says Grails leaves an existing `Content-Disposition` header alone, but this reference page doesn't mention it. Could you add it here too, maybe on the `file` or `inline` entry? It's the other way to keep a file inline, and it takes precedence over `fileName:`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
