codeconsole commented on PR #16407:
URL: https://github.com/apache/grails-core/pull/16407#issuecomment-5850544980
Thanks for the careful review, @matrei. Everything below is in 5dd2f2979c.
**1. `pageClasspath` wiring.** Done the way you suggested: `project.files {
tasks.named('compileGroovyPages', GroovyPageForkCompileTask).get().classpath
}`. The functional test now appends the runtime-only plugin to
`compileGroovyPages.classpath` in the build script and checks its pages are
then generated. That assertion fails with the old `allClasspath` wiring.
`TagLibraryIndexWiringFunctionalSpec`, which includes the no-cycle and
configuration-cache tests, still passes.
**2. Platform types.** The lookup's parent is now
`ClassLoader.platformClassLoader`. The platform-type unit test gained a
`java.sql.Timestamp` controller, which fails with the old `null` parent. I also
added the "necessary, not sufficient" note to `readPluginController`'s javadoc,
using an association's type as the example.
**3. Docs.** Took your wording for line 64, including "For each controller
it covers". The native-image advice now says why: the plugin's own build only
compiled pages for the template copies it saw, so an application template or a
theme earlier on the classpath gives a page it never compiled.
**4. Minor.** Added a comment on why `classesDirs` joins the lookup. I left
the loader opening as it is. I also left out the multi-project fixture, as you
suggested.
Re-run with `cleanTest --no-build-cache`: the 78 tests in
`org.grails.gradle.plugin.scaffolding.*` and
`org.grails.gradle.plugin.views.gsp.*` pass, and so does `codeStyle`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
