codeconsole commented on PR #16407:
URL: https://github.com/apache/grails-core/pull/16407#issuecomment-5859815823
Thanks @sbglasius.
1. **Valid**, in a narrow case. The task has shipped since 8.0.0-M6, so a
build that registered it by hand never sets `pageClasspath` and would lose
every plugin page. Fixed in cfefe7ffdc: an empty `pageClasspath` now checks
nothing, so every plugin controller is expanded as before. The two tests that
relied on it being empty now set it, so they still exercise the check. A new
test covers the unset case, and it fails without the fix.
2. **No change.** `from(task.classpath)` keeps a live reference that is
resolved when the task runs, not a snapshot taken at configuration time. It
would only miss a build that replaces the property object, which is why the
plugin reads it through a closure. The functional test's
append-to-`compileGroovyPages.classpath` step pins that wiring.
3. **No change.** The filter applies only to *other* plugins' controllers in
a consuming project. A plugin's own controllers come from its `classesDirs`
unfiltered, so its build compiles their pages whether or not it has this
change. For a plugin built before `generateScaffoldedViews` existed, the guide
already says the page is "expanded on its first use" ("a controller of a plugin
the application has only at runtime whose pages the plugin's own build did not
compile"). For native images it says to declare the plugin as a dependency.
Nothing regresses either: before this PR, that page couldn't compile in the
consumer anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
