sbglasius commented on PR #16154: URL: https://github.com/apache/grails-core/pull/16154#issuecomment-5911205471
Review note (not inline, because the file is outside the diff): `AbstractDetachedCriteria.groovy:55` still declares `protected List<DynamicFinder> dynamicFinders`, but `DynamicFinder` no longer implements `FinderMethod`. The list now holds `SingleResultFinder`, `ListResultFinder`, `CountFinder` and `ListOrderByFinder`. Nothing fails in this repo because the access is dynamic and generics are erased. A `@CompileStatic` subclass that reads the field as `DynamicFinder` would throw a `ClassCastException`. The declared type should be `List<FinderMethod>`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
