jdaugherty commented on code in PR #16458:
URL: https://github.com/apache/grails-core/pull/16458#discussion_r4154193189


##########
grails-data-hibernate5/grails-plugin/src/main/groovy/grails/orm/bootstrap/HibernateDatastoreSpringInitializer.groovy:
##########
@@ -85,21 +85,15 @@ class HibernateDatastoreSpringInitializer extends 
AbstractDatastoreInitializer {
     @CompileStatic
     void configureDataSources(PropertyResolver config) {
 
-        Set<String> dataSourceNames = new HashSet<String>()
+        // The datastore always creates the default connection source, whether 
or not it is configured
+        Set<String> dataSourceNames = [ConnectionSource.DEFAULT] as Set<String>

Review Comment:
   This is now a LinkedHashSet instead of a HashSet.  It's a minor detail, but 
probably worth covering since you're changing the specific type of 
this.dataSources.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to