jamesfredley commented on PR #16497: URL: https://github.com/apache/grails-core/pull/16497#issuecomment-5984472171
Pushed 2a4a40a746 on top of Walter's port. Addressed on this branch: - @NativeGenerator without @GeneratedValue is generation intent. An assigned custom generator such as @SnowflakeId without @GeneratedValue is not. - GORM native no longer NPEs on a null DatabaseStructure, and it does not invent a nextval default. Native, sequence, and identity are covered through GormDatabase on PostgreSQL. - Sequence and table generators are not auto-increment. Only identity is. - Table-backed generators (MySQL emulation and force_table_use) are not recorded as sequences. - A sequence is stored once, under its bare name, on the synthetic HIBERNATE schema, so the default diff still emits it. It is not also added as app.qs_seq. - Index uniqueness is read from the Hibernate index. A concrete Boolean mismatch is kept. Unknown uniqueness and using are still suppressed. Left open: - Quoted sequence names that differ only by case. Our dedup key preserves that case, but Liquibase 4.27 Sequence.equals folds it, so a public snapshot cannot hold both. - Two sequences with the same bare name in different physical schemas still collapse under the synthetic HIBERNATE schema. Attaching the physical schema would hide them from the default diff. Hibernate 5 is unchanged. grails-data-hibernate5 does not vendor these classes. It still depends on published liquibase-hibernate5 4.27.0, whose snapshot path is the older strategy-string implementation and does not have this H7 generator code. Tests: :grails-data-hibernate7-dbmigration-core:test 42 passed before the last index tweak, then the focused snapshot, index, and dbmigration suites passed after hibernateIndex.isUnique(). checkstyleMain passed on the core module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
