bito-code-review[bot] commented on PR #16533:
URL: https://github.com/apache/grails-core/pull/16533#issuecomment-6007797323
<!-- Bito Reply -->
The suggested change is appropriate. By restricting the exclusion to
non-serializable to-many mappings, you ensure that `type: 'serializable'`
properties—which are stored on the owner table—continue to participate in
unique groups as expected, while still preventing the creation of invalid
unique keys for standard collection tables.
**grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/util/CreateKeyForProps.java**
```
if (grailsProp instanceof HibernateToManyProperty &&
!"serializable".equals(grailsProp.getMappedForm().getType())) {
// The column of a collection property lives in the collection
table, which does not hold the columns
// of the other properties of the group, so a unique group has
no key to create there.
return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
