matrei commented on PR #16533: URL: https://github.com/apache/grails-core/pull/16533#issuecomment-6018196202
Looks good. Hibernate 5 has the same enum and collection problems, so I've opened #16541 against `7.0.x`. On H5 the collection case only logs a failed `alter table ... add constraint` at startup instead of breaking the table. The serializable case doesn't apply there, since H5 never created group keys for serializable properties. One thing for the release notes: enum unique groups now get a real database key. With `dbCreate: create`, duplicates that used to be accepted are rejected. With `update`, if the table already holds duplicates, adding the key fails and is only logged, so the key will be missing until the data is cleaned up. Groups declared only in `mapping` are the ones most likely to have duplicates, since they had no validation at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
