jdaugherty commented on issue #16544: URL: https://github.com/apache/grails-core/issues/16544#issuecomment-6019668893
@jamesfredley I very much dislike the approach of pasting an AI response and ignoring other people's feedback. I've given you feedback multiple times on this, but the way this issue is worded, that feedback has continued to be disregarded. https://github.com/apache/grails-core/pull/16337#issuecomment-6002747095 covers a lot of these problems. Saying we must do X without even discussing X is the wrong approach for a PR description. For example, we must disable groovy doc? No, we should not do that because groovydoc is compile checked and we don't want that check happening only at release. Should we disable groovy doc for individual CI builds? Absolutely, have it be it's own task. Save the time running it over and over. You state this is a discussion, but the ticket PR doesn't list the problems that we then offer & discuss solutions for. It instead says we must do things, including items that directly make our build more unstable and will result in our builds not being fully tested prior to release. This means PRs are going to be opened prior to any discussion. As someone who has been doing a significant number of reviews, especially those created by AI and half baked, it's frustrating. It's frustrating because it wastes my time. This is one of those major issues that needs an architecture discussion up front. The PR needs to list the issues and goals. We then suggest solutions and work through them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
