matrei opened a new pull request, #16557: URL: https://github.com/apache/grails-core/pull/16557
The SDKMAN job in the release workflow only ran `sdkMajorRelease` when the version started with `7.`. As a result, the 8.0.0 release run ([37221485361](https://github.com/apache/grails-core/actions/runs/37221485361)) skipped both SDKMAN steps, and 8.0.0 was never published to SDKMAN. The same condition would also make the next 7.x final release the SDKMAN default instead of 8.0.0. In the SDKMAN vendor plugin, `sdkMajorRelease` releases, announces **and sets the default** version, and `sdkMinorRelease` only releases and announces. This change adds a step that compares the version being released with the newest final release tag (`vX.Y.Z`) in the repository: - the newest final release goes through `sdkMajorRelease` and becomes the default - milestones, release candidates and releases of older lines go through `sdkMinorRelease` and leave the default unchanged This removes the hardcoded major version, so nothing needs to change for the next major release. The fix is on 7.0.x so it reaches every release branch through the normal merge-up, before the next 7.x release. Simulated against the current tags: `8.0.0` → default, while `7.2.4`, `7.2.5`, `8.1.0-M1` and `8.0.0-RC2` are published without changing the default. Note: 8.0.0 still needs a manual `./gradlew sdkMajorRelease` from `grails-forge` at `v8.0.0`, because a re-run of the release would use the workflow file at that tag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
