The GitHub Actions job "Coverage" on 
grails-intellij-plugin.git/feature/grails-view-nodes has failed.
Run started by GitHub user amondel2 (triggered by amondel2).

Head commit for run:
9b414295f72560f4cb24d7bbedb0960f38cdb3a2 / aaron <[email protected]>
Complete the review's account of the non-content-root case in the comments

The review asked for the content-root cause to be stated in the node javadoc,
AGENTS.md and the test javadoc. AGENTS.md covered both halves, but the three
comments in src/ gave only the content-root half, so a reader of any one of them
could still conclude that a nested directory has directory-name fragments to
replace.

Adds the missing half to each: for every other directory the platform calls
setPresentableText and adds no fragments, so the qualified name such as
grails-app.i18n comes from ProjectViewDirectoryHelper.getNodeName through that
field rather than from a fragment. That is why the Views, Configuration and
Initialization titles always rendered without this hook, and why a nested
directory has nothing for postprocess to replace. Closes with the instruction
the review asked for: do not go looking for directory-name fragments on a nested
directory.

The test javadoc also now explains why the directory is registered as a content
entry rather than just that it is, and names the two assertions that make the
test non-vacuous.

No behaviour change; comments only.

Report URL: 
https://github.com/apache/grails-intellij-plugin/actions/runs/37554662657

With regards,
GitHub Actions via GitBox

Reply via email to