borinquenkid commented on PR #16625: URL: https://github.com/apache/grails-core/pull/16625#issuecomment-6205939161
I ran the Hibernate 7 `TraitDefaultValuesProxySpec` integration test locally to check that it fails without the fix. | Main code under test | Result | |---|---| | PR head | 4/4 pass | | Fix reverted (parent of `41cea2f0a4`) | 4/4 fail with `HibernateSystemException: Unable to generate proxy for …` | | Only the serialization fix reverted (parent of `0e9dc2cbae`) | the two `load` features pass; both serialization features fail | The test fails for the reason in #16600, and each half of the fix has coverage that fails without it. The H5 and H7 specs are identical, so I only ran the H7 one. A few observations, none blocking: 1. **The example app sets `hibernate.proxy_factory_class: …ByteBuddyGroovyProxyFactory` explicitly**, and nothing in H7 core's main sources or the docs sets it by default. The test therefore shows the fix works for apps that opt into that factory; it says nothing about the default configuration. If the Groovy factory should apply without configuration, that is a separate gap. It would be worth stating in the description which of the two is intended. 2. **The serialization features depend on `enable_lazy_load_no_trans: true`**, which is added only for these tests. That is a fair use of it, and the description explains why, but the tests don't show what a deserialized proxy does without that flag. 3. **"a loan with its book still lazy survives Java serialization"** checks that the book comes back as an uninitialized proxy whose `id` reads without loading, but it never loads the deserialized book. The standalone serialization feature does cover loading after deserialization, so this is a small gap. 4. The final `!Hibernate.isInitialized(deserialized.book)` in that same feature repeats `bookUninitializedAfter`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
