codeconsole opened a new pull request, #16666:
URL: https://github.com/apache/grails-core/pull/16666
Merges `7.2.x` into `8.0.x`, which brings #16664 to this line.
## Conflict resolution
- `RunningApplicationProcessSpec`: kept the 8.0.x side. #16664 made the last
assertion of `stop terminates a running process and removes the PID file` wait
for the process to exit, because on Windows `Process.isAlive()` still answers
`true` after `stop()` has seen the exit code. 8.0.x already fixed the same race
in 6c76333ea9 and then went further in 3811fcefc7, which polls
`process.toHandle().isAlive()`. That reads the same exit code `stop()` does on
Windows, and on Linux and macOS it does not wait for the JVM's reaper thread.
## Also in this PR
- `grails-core/src/test-cli/.../FileSystemInteractionImplSpec`: the third
copy of the spec, which exists only on 8.0.x, gets the same expectation #16664
gave the other two, `new File('nested', 'missing.txt').path`. Its `projectPath`
also builds the path from `File.canonicalPath`, so it fails on Windows the same
way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
