borinquenkid commented on PR #16701: URL: https://github.com/apache/grails-core/pull/16701#issuecomment-6387619828
Two more commits, both local fixes found after the last review: - `5af2cd2a3f`: the pending removal features point at #16691; #16745 was closed as its duplicate. - `d5774b0d45`: fixes #16748 (`is empty` / `is not empty` on an association that shares a join table and a key column saw the rows of the other one). Hibernate 7 puts the restriction of a many-to-many collection on the join to the element, which the `select 1` of its `exists` subquery never renders; `size()` applies it. `RestrictedCollectionSqmTranslatorFactory`, registered as `hibernate.query.sqm.translator` unless the application sets one, translates `is [not] empty` as `size(...) = 0 / > 0` for a restricted many-to-many collection only; a dialect with its own translator (Sybase) keeps it. Single-table update and delete are covered, multi-table ones are not (documented). Covered for HQL, criteria, negation, update, both shared shapes, and a restricted one-to-many that keeps Hibernate's translation. Full core suite (with the Db2 branch on top): 4275 tests, the only 3 failures the Oracle container not starting locally. The Hibernate bug itself is drafted for the Hibernate Jira. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
