jdaugherty commented on PR #16631:
URL: https://github.com/apache/grails-core/pull/16631#issuecomment-6412546359
@jamesfredley, review 5646564068 is addressed in 6306f94ef7. It is still a
single commit on 9.0.x.
- **Closing the last writer:** releasing the file lock and removing the open
entry now happen together, so a capture opened on the same path cannot join a
writer that is closing. Details are on the thread.
The same commit also includes:
- **Request ids per capture file:** each capture file now numbers its own
requests. Before, a request recorded to two files took its id from one file's
counter, so the other file could give its next request the same id.
- **MongoDB implicit equality:** a document or array compared without an
operator, as in `{"attrs": {"nested": {...}}}`, is now recorded as data at
every level. This covers `filter`, `query`, `q`, `$match`,
`restrictSearchWithMatch`, `arrayFilters`, `partialFilterExpression` and
validators, so a key inside it is never kept as an operator, even one that
starts with `$`.
- **GeoJSON geometries:** the operand of `$geometry` is recorded as data, so
extra fields beside `type` and `coordinates` are not recorded.
- **Failed startup:** if the MongoDB client settings turn out to be invalid,
the capture opened for that connection is closed. If a Neo4j capture cannot
open, the new driver and any embedded server are closed before the failure is
reported, so a corrected startup can reopen the same store.
Each item has tests, and the query-tail guide is updated. Locally,
`:grails-datamapping-core:check` passes (2527 tests plus 128 CLI tests), as do
the MongoDB and Neo4j query-tail specs, CodeNarc and Checkstyle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
