borinquenkid commented on PR #16763: URL: https://github.com/apache/grails-core/pull/16763#issuecomment-6458065845
Pushed commit `0d92e40c7d` addressing both non-blocking notes: - Added clarifying comments to `GrailsHibernateTemplate.java` explaining the necessity of registering the synchronization at `SESSION_SYNCHRONIZATION_ORDER` to prevent Spring's JDBC `ConnectionSynchronization` from closing outer session connections when no in-scope query registers a session synchronization. - Removed the in-scope outer query from the `PROPAGATION_SUPPORTS` lazy-load test in `WithNewSessionLazyLoadSpec.groovy` so the feature directly tests the scenario without registering an in-scope session synchronization. @jdaugherty if everything looks good, please approve when you have a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
