[
https://issues.apache.org/jira/browse/GROOVY-10881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650831#comment-17650831
] ASF GitHub Bot commented on GROOVY-10881: ----------------------------------------- codecov-commenter commented on PR #1836: URL: https://github.com/apache/groovy/pull/1836#issuecomment-1361193224 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1836?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1836](https://codecov.io/gh/apache/groovy/pull/1836?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (59d3a32) into [master](https://codecov.io/gh/apache/groovy/commit/27275071bfcad2225b6ddc0d7dcf54528d3ac29e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2727507) will **decrease** coverage by `0.0003%`. > The diff coverage is `33.3333%`. [](https://codecov.io/gh/apache/groovy/pull/1836?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #1836 +/- ## ================================================== - Coverage 67.7583% 67.7580% -0.0003% Complexity 28281 28281 ================================================== Files 1427 1427 Lines 112556 112558 +2 Branches 19302 19303 +1 ================================================== + Hits 76266 76267 +1 - Misses 29759 29761 +2 + Partials 6531 6530 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1836?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...g/apache/groovy/json/internal/FastStringUtils.java](https://codecov.io/gh/apache/groovy/pull/1836/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0Zhc3RTdHJpbmdVdGlscy5qYXZh) | `55.0000% <33.3333%> (-6.1111%)` | :arrow_down: | | [...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java](https://codecov.io/gh/apache/groovy/pull/1836/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvY29uY3VycmVudGxpbmtlZGhhc2htYXAvQ29uY3VycmVudExpbmtlZEhhc2hNYXAuamF2YQ==) | `45.0593% <0.0000%> (ø)` | | | [...odehaus/groovy/reflection/GeneratedMetaMethod.java](https://codecov.io/gh/apache/groovy/pull/1836/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3JlZmxlY3Rpb24vR2VuZXJhdGVkTWV0YU1ldGhvZC5qYXZh) | `57.6923% <0.0000%> (+0.9615%)` | :arrow_up: | > FastStringUtils does not work in an OSGi environment > ---------------------------------------------------- > > Key: GROOVY-10881 > URL: https://issues.apache.org/jira/browse/GROOVY-10881 > Project: Groovy > Issue Type: Bug > Components: JSON > Reporter: Roy Teeuwen > Priority: Major > > Using the FastStringUtils does not work in an OSGi environment. The > FastStringUtils will be called by the classloader of another bundle, making > the code at > https://github.com/apache/groovy/blob/master/subprojects/groovy-json/src/main/java/org/apache/groovy/json/internal/FastStringUtils.java#L39 > not find the default service loader. > To counter this, I'd like to propose to at least fall back to the > DefaultFastStringService when no FastStringServiceFactory is found > -- This message was sent by Atlassian Jira (v8.20.10#820010)
