[
https://issues.apache.org/jira/browse/GROOVY-10881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654710#comment-17654710
]
Paul King commented on GROOVY-10881:
------------------------------------
{quote}
Is this just stuck in PR review?
{quote}
There are two reasons I haven't merged yet:
# I'd like to reproduce the error and fix (it's been a while since I played
with OSGi environments) though the logic looks fine
# The change sort of hides problems in non-OSGi environments. If someone was
using a custom fast string service (like groovy-json-direct or their own) and
had some kind of classpath or configuration issue, they will not fail early and
draw attention to their issue. I am still pondering if this is a problem. I
imagine it's a very small audience we are talking about.
> FastStringUtils does not work in an OSGi environment
> ----------------------------------------------------
>
> Key: GROOVY-10881
> URL: https://issues.apache.org/jira/browse/GROOVY-10881
> Project: Groovy
> Issue Type: Bug
> Components: JSON
> Reporter: Roy Teeuwen
> Priority: Major
>
> Using the FastStringUtils does not work in an OSGi environment. The
> FastStringUtils will be called by the classloader of another bundle, making
> the code at
> https://github.com/apache/groovy/blob/master/subprojects/groovy-json/src/main/java/org/apache/groovy/json/internal/FastStringUtils.java#L39
> not find the default service loader.
> To counter this, I'd like to propose to at least fall back to the
> DefaultFastStringService when no FastStringServiceFactory is found
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
