paulk-asert commented on code in PR #2154:
URL: https://github.com/apache/groovy/pull/2154#discussion_r1970770095
##########
build-logic/src/main/groovy/org/apache/groovy/gradle/JarJarTask.groovy:
##########
@@ -169,16 +168,9 @@ class JarJarTask extends DefaultTask {
it.into(outputFile.parentFile)
it.rename { outputFile.name }
}
- project.ant.jar(destfile: outputFile, update: true, index: true,
manifest: manifestFile, modificationtime: tstamp) {
- manifest {
- // because we don't want to use JDK 1.8.0_91, we don't
care and it will
- // introduce cache misses
- attribute(name: 'Created-By', value: 'Gradle')
Review Comment:
-1 on deleting this
MANIFEST.MF now contains something like:
> Created-By: 17.0.13+11-LTS (Azul Systems, Inc.)
Instead of:
> Created-By: Gradle
Which, as well as impacting Gradle cache, breaks our reproducible build
goal. "Created-By" is already in the `excludedFromManifest` list, so I guess
can't really be excluded, hence its forced value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
