paulk-asert commented on code in PR #2154:
URL: https://github.com/apache/groovy/pull/2154#discussion_r2000136302
##########
build-logic/src/main/groovy/org/apache/groovy/gradle/JarJarTask.groovy:
##########
@@ -169,16 +168,9 @@ class JarJarTask extends DefaultTask {
it.into(outputFile.parentFile)
it.rename { outputFile.name }
}
- project.ant.jar(destfile: outputFile, update: true, index: true,
manifest: manifestFile, modificationtime: tstamp) {
- manifest {
- // because we don't want to use JDK 1.8.0_91, we don't
care and it will
- // introduce cache misses
- attribute(name: 'Created-By', value: 'Gradle')
Review Comment:
+1 for all refactoring changes and removing Ant-Version, Created-By,
Extension-Name, Tool. My preference is to keep OSGi changes in a separate PR,
ideally with some testing, but at least to make it easier/cleaner for manual
testing. We can add Bundle-ClassPath to list of removed attributes since we set
to default value anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
