[
https://issues.apache.org/jira/browse/GROOVY-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18061877#comment-18061877
] ASF GitHub Bot commented on GROOVY-9381: ---------------------------------------- codecov-commenter commented on PR #2386: URL: https://github.com/apache/groovy/pull/2386#issuecomment-3977746778 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2386?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `77.38589%` with `109 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.7999%. Comparing base ([`4f33a90`](https://app.codecov.io/gh/apache/groovy/commit/4f33a90d3f8b4cc4a511ef0aebbe9b9af334be5c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8513eb6`](https://app.codecov.io/gh/apache/groovy/commit/8513eb60f56ee943690f0a29cb112f9019c4ae7c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2386?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [src/main/java/groovy/transform/AsyncUtils.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Ftransform%2FAsyncUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvdHJhbnNmb3JtL0FzeW5jVXRpbHMuamF2YQ==) | 74.2857% | [25 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/groovy/concurrent/AwaitableAdapterRegistry.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Fconcurrent%2FAwaitableAdapterRegistry.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvY29uY3VycmVudC9Bd2FpdGFibGVBZGFwdGVyUmVnaXN0cnkuamF2YQ==) | 39.6226% | [24 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ehaus/groovy/transform/AsyncASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FAsyncASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9Bc3luY0FTVFRyYW5zZm9ybWF0aW9uLmphdmE=) | 85.0394% | [7 Missing and 12 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...n/java/groovy/concurrent/AsyncStreamGenerator.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Fconcurrent%2FAsyncStreamGenerator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvY29uY3VycmVudC9Bc3luY1N0cmVhbUdlbmVyYXRvci5qYXZh) | 60.0000% | [13 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/groovy/parser/antlr4/AstBuilder.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FAstBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0FzdEJ1aWxkZXIuamF2YQ==) | 93.5897% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [src/main/java/groovy/concurrent/AsyncStream.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Fconcurrent%2FAsyncStream.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvY29uY3VycmVudC9Bc3luY1N0cmVhbS5qYXZh) | 75.0000% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/groovy/concurrent/AwaitableAdapter.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Fconcurrent%2FAwaitableAdapter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvY29uY3VycmVudC9Bd2FpdGFibGVBZGFwdGVyLmphdmE=) | 50.0000% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [src/main/java/groovy/concurrent/GroovyPromise.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Fconcurrent%2FGroovyPromise.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvY29uY3VycmVudC9Hcm9vdnlQcm9taXNlLmphdmE=) | 95.6522% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2386 +/- ## ================================================== + Coverage 66.7490% 66.7999% +0.0508% - Complexity 29842 29971 +129 ================================================== Files 1382 1391 +9 Lines 116126 116608 +482 Branches 20473 20554 +81 ================================================== + Hits 77513 77894 +381 - Misses 32279 32347 +68 - Partials 6334 6367 +33 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2386?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [src/main/java/groovy/concurrent/AwaitResult.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Fconcurrent%2FAwaitResult.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvY29uY3VycmVudC9Bd2FpdFJlc3VsdC5qYXZh) | `100.0000% <100.0000%> (ø)` | | | [src/main/java/groovy/concurrent/Awaitable.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Fconcurrent%2FAwaitable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvY29uY3VycmVudC9Bd2FpdGFibGUuamF2YQ==) | `100.0000% <100.0000%> (ø)` | | | [...ain/java/org/codehaus/groovy/ast/ModifierNode.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fast%2FModifierNode.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC9Nb2RpZmllck5vZGUuamF2YQ==) | `77.7778% <100.0000%> (+0.4193%)` | :arrow_up: | | [src/main/java/groovy/concurrent/AsyncStream.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Fconcurrent%2FAsyncStream.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvY29uY3VycmVudC9Bc3luY1N0cmVhbS5qYXZh) | `75.0000% <75.0000%> (ø)` | | | [.../main/java/groovy/concurrent/AwaitableAdapter.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Fconcurrent%2FAwaitableAdapter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvY29uY3VycmVudC9Bd2FpdGFibGVBZGFwdGVyLmphdmE=) | `50.0000% <50.0000%> (ø)` | | | [src/main/java/groovy/concurrent/GroovyPromise.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Fconcurrent%2FGroovyPromise.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvY29uY3VycmVudC9Hcm9vdnlQcm9taXNlLmphdmE=) | `95.6522% <95.6522%> (ø)` | | | [...va/org/apache/groovy/parser/antlr4/AstBuilder.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FAstBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0FzdEJ1aWxkZXIuamF2YQ==) | `86.7044% <93.5897%> (+0.2424%)` | :arrow_up: | | [...n/java/groovy/concurrent/AsyncStreamGenerator.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Fconcurrent%2FAsyncStreamGenerator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvY29uY3VycmVudC9Bc3luY1N0cmVhbUdlbmVyYXRvci5qYXZh) | `60.0000% <60.0000%> (ø)` | | | [...ehaus/groovy/transform/AsyncASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FAsyncASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9Bc3luY0FTVFRyYW5zZm9ybWF0aW9uLmphdmE=) | `85.0394% <85.0394%> (ø)` | | | [...va/groovy/concurrent/AwaitableAdapterRegistry.java](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Fconcurrent%2FAwaitableAdapterRegistry.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvY29uY3VycmVudC9Bd2FpdGFibGVBZGFwdGVyUmVnaXN0cnkuamF2YQ==) | `39.6226% <39.6226%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/apache/groovy/pull/2386?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2386/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Support async/await like ES7 > ---------------------------- > > Key: GROOVY-9381 > URL: https://issues.apache.org/jira/browse/GROOVY-9381 > Project: Groovy > Issue Type: New Feature > Reporter: Daniel Sun > Priority: Major > > Here is an example to show proposed syntax and backend API(Java's > {{CompletableFuture}} or GPars's {{{}Promise{}}}), but I think it's better > for Groovy to have its own {{Promise}} to decouple with Java API because > async/await as a language feature should be as stable as possible. > {{async}} will generate the {{Awaitable}} instance such as Groovy {{Promise}} > implementing the {{Awaitable}} interface, and {{await}} can wait for any > {{Awaitable}} instance to complete and unwrap it for the result. > {code:java} > /** > * 1. An async function that simulates a network API call. > * The 'async' keyword implies it runs asynchronously without blocking. > */ > async fetchUserData(userId) { > println "Starting to fetch data for user ${userId}..." > > // Simulate a 1-second network delay. > Thread.sleep(1000) > > println "Fetch successful!" > // The 'async' function implicitly returns a "CompletableFuture" or > "Promise" containing this value. > return [userId: userId, name: 'Daniel'] > } > /** > * 2. An async function that uses 'await' to consume the result. > */ > async processUserData() { > println "Process started, preparing to fetch user data..." > > try { > // 'await' pauses this function until fetchUserData completes > // and returns the final result directly. > def user = await fetchUserData(1) > > println "Data received: ${user}" > return "Processing complete for ${user.name}." > > } catch (Exception e) { > return "An error occurred: ${e.message}" > } > } > // --- Execution --- > println "Script starting..." > // Kick off the entire asynchronous process. > def future = processUserData() > // This line executes immediately, proving the process is non-blocking. > println "Script continues to run while user data is being fetched in the > background..." > def result = future.get() > println "Script finished: ${result}" > {code} > Use async/await with closure or lambda expression: > {code} > // use closure > def c = async { > println "Process started, preparing to fetch user data..." > > try { > // 'await' pauses this function until fetchUserData completes > // and returns the final result directly. > def user = await fetchUserData(1) > > println "Data received: ${user}" > return "Processing complete for ${user.name}." > > } catch (Exception e) { > return "An error occurred: ${e.message}" > } > } > def future = c() > {code} > {code} > // use lambda expression > def c = async () -> { > println "Process started, preparing to fetch user data..." > > try { > // 'await' pauses this function until fetchUserData completes > // and returns the final result directly. > def user = await fetchUserData(1) > > println "Data received: ${user}" > return "Processing complete for ${user.name}." > > } catch (Exception e) { > return "An error occurred: ${e.message}" > } > } > def future = c() > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
