[
https://issues.apache.org/jira/browse/GROOVY-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18082114#comment-18082114
] ASF GitHub Bot commented on GROOVY-12022: ----------------------------------------- codecov-commenter commented on PR #2546: URL: https://github.com/apache/groovy/pull/2546#issuecomment-4490127022 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2546?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.1497%. Comparing base ([`f1f1efa`](https://app.codecov.io/gh/apache/groovy/commit/f1f1efa84271584bf47fe425763f9512d2e1daf6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b2cb3f2`](https://app.codecov.io/gh/apache/groovy/commit/b2cb3f235fb6fd2b3927f9d259f39165e9fe1601?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2546 +/- ## ================================================== - Coverage 68.1956% 68.1497% -0.0460% - Complexity 32936 32964 +28 ================================================== Files 1503 1504 +1 Lines 125706 125782 +76 Branches 22743 22759 +16 ================================================== - Hits 85726 85720 -6 - Misses 32422 32514 +92 + Partials 7558 7548 -10 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2546?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...sm/indy/sc/IndyStaticTypesMultiTypeDispatcher.java](https://app.codecov.io/gh/apache/groovy/pull/2546?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2Findy%2Fsc%2FIndyStaticTypesMultiTypeDispatcher.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9pbmR5L3NjL0luZHlTdGF0aWNUeXBlc011bHRpVHlwZURpc3BhdGNoZXIuamF2YQ==) | `0.0000% <ø> (-100.0000%)` | :arrow_down: | | [...y/classgen/asm/sc/StaticTypesWriterController.java](https://app.codecov.io/gh/apache/groovy/pull/2546?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2Fsc%2FStaticTypesWriterController.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9zYy9TdGF0aWNUeXBlc1dyaXRlckNvbnRyb2xsZXIuamF2YQ==) | `91.2500% <100.0000%> (-0.3163%)` | :arrow_down: | ... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2546/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > deprecate IndyStaticTypesMultiTypeDispatcher > -------------------------------------------- > > Key: GROOVY-12022 > URL: https://issues.apache.org/jira/browse/GROOVY-12022 > Project: Groovy > Issue Type: Bug > Reporter: Jochen Theodorou > Assignee: Jochen Theodorou > Priority: Minor > > In IndyStaticTypesMultiTypeDispatcher.java (lines 95-99), the get and set > names are swapped for float and boolean arrays (using name "get" for a > descriptor that returns void and takes a value). > The code works because the IndyInterface.staticArrayAccess bootstrap method > ignores the name parameter and uses the parameter count of the MethodType > instead. > But in general I see no reason to use invokedynamic here. The non-indy code > uses BytecodeInterface8 to access the specific code paths for array access > and should be faster than the indy version since it is a "simple" static > method invocation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
