[ 
https://issues.apache.org/jira/browse/GROOVY-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18082119#comment-18082119
 ] 

ASF GitHub Bot commented on GROOVY-12022:
-----------------------------------------

testlens-app[bot] commented on PR #2546:
URL: https://github.com/apache/groovy/pull/2546#issuecomment-4490224776

   ## ✅ All tests passed ✅
   
   🏷️ Commit: b2cb3f235fb6fd2b3927f9d259f39165e9fe1601
   ▶️ Tests:  198868 executed
   ⚪️ Checks: 56/56 completed
   
   ---
   _Learn more about TestLens at [testlens.app](https://testlens.app)._
   




> deprecate IndyStaticTypesMultiTypeDispatcher
> --------------------------------------------
>
>                 Key: GROOVY-12022
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12022
>             Project: Groovy
>          Issue Type: Bug
>            Reporter: Jochen Theodorou
>            Assignee: Jochen Theodorou
>            Priority: Minor
>
> In IndyStaticTypesMultiTypeDispatcher.java (lines 95-99), the get and set 
> names are swapped for float and boolean arrays (using name "get" for a 
> descriptor that returns void and takes a value).
>  The code works because the IndyInterface.staticArrayAccess bootstrap method 
> ignores the name parameter and uses the parameter count of the MethodType 
> instead.
> But in general I see no reason to use invokedynamic here. The non-indy code 
> uses BytecodeInterface8 to access the specific code paths for array access 
> and should be faster than the indy version since it is a "simple" static 
> method invocation. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to