[ 
https://issues.apache.org/jira/browse/GROOVY-12309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18110312#comment-18110312
 ] 

ASF GitHub Bot commented on GROOVY-12309:
-----------------------------------------

codecov-commenter commented on PR #2851:
URL: https://github.com/apache/groovy/pull/2851#issuecomment-5495387036

   ## 
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2851?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 70.7947%. Comparing base 
([`03e303e`](https://app.codecov.io/gh/apache/groovy/commit/03e303e9fdb2715c1be064849984c19a14cab4b8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`d753ae5`](https://app.codecov.io/gh/apache/groovy/commit/d753ae51c53fc041a5ab24959fd3cc4fabc22af4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/groovy/pull/2851/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/2851?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #2851        +/-   ##
   ==================================================
   + Coverage     70.7930%   70.7947%   +0.0017%     
   - Complexity      36966      36968         +2     
   ==================================================
     Files            1576       1576                
     Lines          134769     134770         +1     
     Branches        24946      24947         +1     
   ==================================================
   + Hits            95407      95410         +3     
   + Misses          30761      30759         -2     
     Partials         8601       8601                
   ```
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/2851?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[...oovy/classgen/asm/sc/StaticTypesClosureWriter.java](https://app.codecov.io/gh/apache/groovy/pull/2851?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2Fsc%2FStaticTypesClosureWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9zYy9TdGF0aWNUeXBlc0Nsb3N1cmVXcml0ZXIuamF2YQ==)
 | `62.1849% <100.0000%> (-3.0694%)` | :arrow_down: |
   
   ... and [9 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/groovy/pull/2851/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> Closure calls with Object[] parameter under static compilation get the wrong 
> argument
> -------------------------------------------------------------------------------------
>
>                 Key: GROOVY-12309
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12309
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 6.0.0-alpha-1, 5.0.3, 4.0.31
>            Reporter: Björn Kautler
>            Assignee: Jochen Theodorou
>            Priority: Major
>
> With
> {code:java}
> class Foo {
>   def foo() {
>     { Object[] foo -> println(foo) }.call(new Object[] { 'foo' })
>   }
> }
> new Foo().foo() {code}
> you get {{[foo]}} printed.
> Adding {{@groovy.transform.CompileStatic}} it prints {{{}[[foo]]{}}}.
> Removing the {{Object[]}} with added static-compilation it again prints 
> {{{}[foo]{}}}.
> The closure under static compilation should get the same parameter and not 
> wrapped in another {{{}Object[]{}}}.
> This is caused by the {{call}} / {{doCall}} methods generated for the closure.
> The {{call}} call where it happens in production is a precompiled Java code 
> that gives the same argument in either case.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to