[
https://issues.apache.org/jira/browse/GROOVY-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113238#comment-18113238
] ASF GitHub Bot commented on GROOVY-12390: ----------------------------------------- codecov-commenter commented on PR #2912: URL: https://github.com/apache/groovy/pull/2912#issuecomment-5599386202 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2912?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `91.66667%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 71.1946%. Comparing base ([`17b99a8`](https://app.codecov.io/gh/apache/groovy/commit/17b99a8c6c942b207257090e7ce795b34f58d8b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd5554d`](https://app.codecov.io/gh/apache/groovy/commit/fd5554d8bc70c90b0d7cf0586840b6d1f8bdd3ed?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2912?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/groovy/internal/util/ImmutableTypes.java](https://app.codecov.io/gh/apache/groovy/pull/2912?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Finternal%2Futil%2FImmutableTypes.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9pbnRlcm5hbC91dGlsL0ltbXV0YWJsZVR5cGVzLmphdmE=) | 87.5000% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2912?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2912?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2912 +/- ## ================================================== + Coverage 71.1943% 71.1946% +0.0002% - Complexity 37632 37635 +3 ================================================== Files 1581 1582 +1 Lines 136251 136252 +1 Branches 25311 25310 -1 ================================================== + Hits 97003 97004 +1 Misses 30511 30511 Partials 8737 8737 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2912?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/groovy/ast/tools/ImmutablePropertyUtils.java](https://app.codecov.io/gh/apache/groovy/pull/2912?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fast%2Ftools%2FImmutablePropertyUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9hc3QvdG9vbHMvSW1tdXRhYmxlUHJvcGVydHlVdGlscy5qYXZh) | `74.0741% <100.0000%> (-0.9259%)` | :arrow_down: | | [.../java/org/codehaus/groovy/runtime/GStringImpl.java](https://app.codecov.io/gh/apache/groovy/pull/2912?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FGStringImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvR1N0cmluZ0ltcGwuamF2YQ==) | `95.6522% <100.0000%> (ø)` | | | [...rg/apache/groovy/internal/util/ImmutableTypes.java](https://app.codecov.io/gh/apache/groovy/pull/2912?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Finternal%2Futil%2FImmutableTypes.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9pbnRlcm5hbC91dGlsL0ltbXV0YWJsZVR5cGVzLmphdmE=) | `87.5000% <87.5000%> (ø)` | | ... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2912/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > GStringImpl: constant-value check pulls the compiler's ClassHelper into the > runtime > ----------------------------------------------------------------------------------- > > Key: GROOVY-12390 > URL: https://issues.apache.org/jira/browse/GROOVY-12390 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > > Involves: checkValuesStringConstant calls > ImmutablePropertyUtils.builtinOrMarkedImmutableClass, whose class initialiser > builds ClassNodes through ClassHelper, which reflects over the JDK types. The > two checks it needs, a name set and an annotation test, belong in a runtime > utility that the AST utility delegates to. > Impact on normal usage: positive. The first GString with a non-trivial value > stops loading a few dozen compiler classes, and native-image reachability > shrinks accordingly. Behaviour is unchanged. This one is worth doing > regardless of Android. -- This message was sent by Atlassian Jira (v8.20.10#820010)
