[ 
https://issues.apache.org/jira/browse/GROOVY-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113301#comment-18113301
 ] 

ASF GitHub Bot commented on GROOVY-12390:
-----------------------------------------

testlens-app[bot] commented on PR #2912:
URL: https://github.com/apache/groovy/pull/2912#issuecomment-5601792337

   ## ✅ All tests passed ✅
   
   🏷️ Commit: fd5554d8bc70c90b0d7cf0586840b6d1f8bdd3ed
   ▶️ Tests:  113436 executed
   ⚪️ Checks: 33/33 completed
   
   ---
   _Learn more about TestLens at 
[testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   




> GStringImpl: constant-value check pulls the compiler's ClassHelper into the 
> runtime
> -----------------------------------------------------------------------------------
>
>                 Key: GROOVY-12390
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12390
>             Project: Groovy
>          Issue Type: Improvement
>            Reporter: Paul King
>            Assignee: Paul King
>            Priority: Major
>
> Involves: checkValuesStringConstant calls 
> ImmutablePropertyUtils.builtinOrMarkedImmutableClass, whose class initialiser 
> builds ClassNodes through ClassHelper, which reflects over the JDK types. The 
> two checks it needs, a name set and an annotation test, belong in a runtime 
> utility that the AST utility delegates to.
> Impact on normal usage: positive. The first GString with a non-trivial value 
> stops loading a few dozen compiler classes, and native-image reachability 
> shrinks accordingly. Behaviour is unchanged. This one is worth doing 
> regardless of Android.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to