[
https://issues.apache.org/jira/browse/GROOVY-12425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18116990#comment-18116990
] ASF GitHub Bot commented on GROOVY-12425: ----------------------------------------- codecov-commenter commented on PR #2944: URL: https://github.com/apache/groovy/pull/2944#issuecomment-5740414731 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2944?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 71.6042%. Comparing base ([`40e59c5`](https://app.codecov.io/gh/apache/groovy/commit/40e59c5c116e53e96013a06a97c09923b7752969?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0884b79`](https://app.codecov.io/gh/apache/groovy/commit/0884b79b43c5988a88d5ab90fe74628752089add?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2944?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2944 +/- ## ================================================== - Coverage 71.6067% 71.6042% -0.0025% + Complexity 38062 38059 -3 ================================================== Files 1588 1588 Lines 137078 137080 +2 Branches 25507 25507 ================================================== - Hits 98157 98155 -2 - Misses 30014 30016 +2 - Partials 8907 8909 +2 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2944?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/groovy/parser/antlr4/AstBuilder.java](https://app.codecov.io/gh/apache/groovy/pull/2944?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FAstBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0FzdEJ1aWxkZXIuamF2YQ==) | `87.1221% <100.0000%> (+0.0096%)` | :arrow_up: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2944/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Refine error message for unclosed type argument > ----------------------------------------------- > > Key: GROOVY-12425 > URL: https://issues.apache.org/jira/browse/GROOVY-12425 > Project: Groovy > Issue Type: Improvement > Reporter: Daniel Sun > Priority: Major > > The caret position is not accurate, column *13* should be better. > {code} > @Test > void 'unclosed type argument'() { > expectParseError '''\ > |List<Integer list2 = new ArrayList<Integer>() > |'''.stripMargin(), '''\ > |Missing '>' @ line 1, column 1. > | List<Integer list2 = new ArrayList<Integer>() > | ^ > | > |1 error > |'''.stripMargin() > } > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
