[
https://issues.apache.org/jira/browse/GROOVY-12425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18116998#comment-18116998
]
ASF GitHub Bot commented on GROOVY-12425:
-----------------------------------------
github-actions[bot] commented on PR #2944:
URL: https://github.com/apache/groovy/pull/2944#issuecomment-5740620856
### JMH summary — indy (commit `4d2a730`)
Speedup vs trailing 90-day baseline on gh-pages. Higher = faster.
`1.00` = in line with history. Per-benchmark ratio, geomean within group.
Time-per-op units inverted so direction is consistent. The *calibrated*
column divides out this runner's speed vs the baseline hardware, as
measured by Groovy-independent pure-Java ruler benchmarks.
| Group | Speedup | Calibrated | n |
|--------|---------|------------|---|
| bench | 1.256 × | 1.066 × | 124 |
| core | 4.226 × | 3.800 × | 108 |
| grails | 2.297 × | 2.414 × | 80 |
> ⚠️ **3 benchmarks at least 1.5× slower than the 90-day baseline:**
> - `org.apache.groovy.bench.AryBench.groovyCS ( {"n":"1000000"} )` — 2.27×
slower (calibrated)
> - `org.apache.groovy.bench.StaticMethodCallIndyBench.staticChain_groovyCS`
— 1.60× slower (calibrated)
> -
`org.apache.groovy.bench.dispatch.CallsiteBench.dispatch_3_polymorphic_groovy`
— 1.52× slower (calibrated)
> ⚠️ Runner speed differs ≥15% from the historical baseline hardware for:
bench, core-hz. Raw speedups are not meaningful for those parts — use the
calibrated column.
<sub>Runner calibration (this run vs baseline hardware): bench 1.19× (27
rulers) · core-ag 0.96× (3 rulers) · core-hz 1.43× (3 rulers) · grails-ad 0.96×
(3 rulers) · grails-ez 0.94× (3 rulers)</sub>
<sub>Baseline: <code>dev/bench/jmh/<part>/indy/data.js</code> on
gh-pages, trailing 90 days. <a
href="https://apache.github.io/groovy/dev/bench/jmh/summary.html">Daily
dashboard</a> · <a
href="https://apache.github.io/groovy/dev/bench/jmh/">Per-suite raw
data</a></sub>
<!
> Refine error message for unclosed type argument
> -----------------------------------------------
>
> Key: GROOVY-12425
> URL: https://issues.apache.org/jira/browse/GROOVY-12425
> Project: Groovy
> Issue Type: Improvement
> Reporter: Daniel Sun
> Priority: Major
>
> The caret position is not accurate, column *13* should be better.
> {code}
> @Test
> void 'unclosed type argument'() {
> expectParseError '''\
> |List<Integer list2 = new ArrayList<Integer>()
> |'''.stripMargin(), '''\
> |Missing '>' @ line 1, column 1.
> | List<Integer list2 = new ArrayList<Integer>()
> | ^
> |
> |1 error
> |'''.stripMargin()
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)