blackdrag commented on PR #2958: URL: https://github.com/apache/groovy/pull/2958#issuecomment-6080727375
I do not like the potential drift into the varargs penalty by this. Effectively this change adds 1<<19 to each of the four lossy cases. I suggest to instead change the distance table for these cases and add 1<<9. Why? Because this is optimized for a 255 arguments maximum imposed by the JVM allowing only 255 parameter slots (long and double actually take 2 slots). Should there be problems with more than 255 cases we should make a different issue out of that, because if we really want to support arbitrary lengths there are several places we have to change, in the compiler too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
