paulk-asert commented on PR #2958: URL: https://github.com/apache/groovy/pull/2958#issuecomment-6096673270
I also added a test to lock in the existing varargs behavior: since the penalty stays below `VARGS_SHIFT`, with `m(float)` and `m(double...)` a BigDecimal argument still selects `m(float)`, as before. For comparison, Java, Kotlin and Scala all reject BigDecimal/BigInteger to float/double outright, so there's no direct precedent. For the closest one, lossy primitive widening (long to float), both Java and Scala prefer a non-varargs `m(float)` over `m(double...)`, so keeping the penalty below the varargs bits matches that. Preferring double over float for BigDecimal remains a Groovy-specific choice; it restores the pre-4.0.4 behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
